Allow Caches to return a name borrowed from themselves
#130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful when the name comes not from the handle, but from the cache itself.
For example, if the cache is a sort of `Vec<{name: String, contents: Source<...>}>`
(the the handles are `usize`s).
|
Never mind, this works with my own code, but not all of ariadne's. I tried another fix, but it breaks when trying to Footnotes |
Yes, I think there are several fundamental problems with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when the name comes not from the handle, but from the cache itself.
For example, if the cache is a sort of
Vec<{name: String, contents: Source<...>}>(then the handles areusizes).